Review Request 111347: Fix overloaded-virtual of computeCompletions.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111347/
-----------------------------------------------------------

(Updated July 1, 2013, 5:48 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Description
-------

MissingIncludeCompletionWorker::computeCompletions causes an overloaded-virtual warning when building kdevelop. Upon investigation, it appears that it was intended to override CodeCompletionWorker::computeCompletions, but the third parameter is incorrect.

KDevelop was crashing left and right and with this change seems a bit more stable.


Diffs
-----

  languages/cpp/codecompletion/missingincludemodel.h 7c5673e 
  languages/cpp/codecompletion/missingincludemodel.cpp 346e8a1 

Diff: http://git.reviewboard.kde.org/r/111347/diff/


Testing
-------

Built, ran. Verified that this overloaded-virtual warning no longer occurs.


File Attachments
----------------

git format-patch
  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/01/0001-Fix-overloaded-virtual-of-computeCompletions.patch


Thanks,

Ben Wagner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130701/39477474/attachment.html>