Review Request 111347: Fix overloaded-virtual of computeCompletions.

Ben Wagner bungeman at gmail.com
Mon Jul 1 16:22:18 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111347/
-----------------------------------------------------------

(Updated July 1, 2013, 4:22 p.m.)


Review request for KDevelop.


Changes
-------

Attaching output of git format-patch.


Description
-------

MissingIncludeCompletionWorker::computeCompletions causes an overloaded-virtual warning when building kdevelop. Upon investigation, it appears that it was intended to override CodeCompletionWorker::computeCompletions, but the third parameter is incorrect.

KDevelop was crashing left and right and with this change seems a bit more stable.


Diffs
-----

  languages/cpp/codecompletion/missingincludemodel.h 7c5673e 
  languages/cpp/codecompletion/missingincludemodel.cpp 346e8a1 

Diff: http://git.reviewboard.kde.org/r/111347/diff/


Testing
-------

Built, ran. Verified that this overloaded-virtual warning no longer occurs.


File Attachments (updated)
----------------

git format-patch
  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/01/0001-Fix-overloaded-virtual-of-computeCompletions.patch


Thanks,

Ben Wagner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130701/13a28fbd/attachment.html>


More information about the KDevelop-devel mailing list