Review Request 108689: Make KJob realize that there is an error.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108689/#review26471
-----------------------------------------------------------

Ship it!


please commit into 4.5 branch

thanks

- Milian Wolff


On Jan. 31, 2013, 8:01 p.m., Eli MacKenzie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108689/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2013, 8:01 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Merely setting the error number and error text isn't enough to cause KJob to detect the state of the job, emitResult must be called as well. Otherwise, the job not starting is never detected. I've added a change to set the VcsJob::status as well, might as well be thorough about marking the job as a failure.
> 
> 
> Diffs
> -----
> 
>   vcs/dvcs/dvcsjob.cpp 07f2e033ac05303518baf15ae7659704ada12e5b 
> 
> Diff: http://git.reviewboard.kde.org/r/108689/diff/
> 
> 
> Testing
> -------
> 
> I discovered this while trying to understand why KDevelop froze when trying to open the revision graph. This fixes the freeze, the cause of the revision graph not opening is a separate review.
> 
> 
> Thanks,
> 
> Eli MacKenzie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130131/679049ce/attachment.html>