Review Request 108688: Fix crash in OutputModel::flushLineBuffer()

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108688/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

Fix crash in OutputModel::flushLineBuffer()

In case we try to call beginInsertRows() with invalid indices we will
trigger an assert in qabstractitemmodel.cpp.

Backtrace (reduced):
5  0x00007ffff5a7caac in qt_assert (assertion=0x7ffff5ccce63 "last >=
first", file=0x7ffff5cccbe0
"/home/krf/devel/src/qt/src/corelib/kernel/qabstractitemmodel.cpp",
line=2413) at /home/krf/devel/src/qt/src/corelib/global/qglobal.cpp:2018
6  0x00007ffff5bba5d6 in QAbstractItemModel::beginInsertRows
(this=0x72226b0, parent=..., first=35, last=34) at
/home/krf/devel/src/qt/src/corelib/kernel/qabstractitemmodel.cpp:2413
7  0x00007fffec45136f in KDevelop::OutputModel::flushLineBuffer
(this=0x72226b0) at
/home/krf/devel/src/kdevplatform/outputview/outputmodel.cpp:284
8  0x00007fffc079c6fa in CTestRunJob::processFinished (this=0x703a240,
job=0x7212ce0) at
/home/krf/devel/src/kdevelop/projectmanagers/cmake/testing/ctestrunjob.cpp:140

(gdb) p d->m_lineBuffer.size()
$1 = 0


Diffs
-----

  outputview/outputmodel.cpp c4dd9c9d057aa2de92fb25ee6929acc16ef6e7af 

Diff: http://git.reviewboard.kde.org/r/108688/diff/


Testing
-------


Thanks,

Kevin Funk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130131/91d2d198/attachment.html>