Review Request 108556: Use proper target exe path calculation for CTests

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108556/#review26373
-----------------------------------------------------------


This review has been submitted with commit 855878fee5dff88363ad8db7fcc836234d02384b by Aleix Pol on behalf of Sergey Vidyuk to branch 4.5.

- Commit Hook


On Jan. 22, 2013, 7:20 p.m., Sergey Vidyuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108556/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2013, 7:20 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Calculation of the executable path is done through the
> ProjectExecutableTargetItem which respects RUNTIME_OUTPUT_DIRECTORY
> target property and CMAKE_RUNTIME_OUTPUT_DIRECTORY variable values.
> 
> Addtionally Test::executable is not modified if kde4_add_unit_test
> detection logick failed (target name calculated in the detection block
> dies not exists in the code).
> 
> Note: this commit is made for 4.5 since at least for me wrong detection of unit test executable path is critical bug. If it's too late to add this fix to the upcommig release I can rebase it on master.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/parser/cmakeprojectvisitor.cpp 27d81e1 
>   projectmanagers/cmake/parser/cmaketypes.h be09d67 
>   projectmanagers/cmake/testing/ctestutils.cpp 09c83af 
>   projectmanagers/cmake/tests/ctestfindsuitestest.cpp 9e81e3b 
>   projectmanagers/cmake/tests/manual/unit_tests/CMakeLists.txt 21ba34c 
>   projectmanagers/cmake/tests/manual/unit_tests_kde/CMakeLists.txt cc49da0 
> 
> Diff: http://git.reviewboard.kde.org/r/108556/diff/
> 
> 
> Testing
> -------
> 
>  * Manually tested on a project modifying runtime target locations through the CMAKE_RUNTIME_OUTPUT_DIRECTORY cmake variable.
>  * Run modified unit tests.
> 
> 
> Thanks,
> 
> Sergey Vidyuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130129/caa020c2/attachment.html>