Review Request 108527: Don't use WorstPriority in ParseProjectJob to make it possible to create jobs with worse

Milian Wolff mail at milianw.de
Mon Jan 21 16:57:58 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108527/#review25910
-----------------------------------------------------------

Ship it!


Ah that explains my other question.

- Milian Wolff


On Jan. 21, 2013, 3:24 p.m., Niko Sams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108527/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2013, 3:24 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Php needs to reschedule documents for parsing if unknown symbols are encountered. This is done by adding them to the background parser with a lower priority.
> 
> However this doesn't work on initial parsing when the project is opened as there all are added with WorstPriority - and so can't get added with worse priority.
> 
> This patch makes that possible by using another lower priority in ParseProjectJob.
> 
> 
> Diffs
> -----
> 
>   language/backgroundparser/backgroundparser.h 4c38d1a 
>   language/backgroundparser/parseprojectjob.cpp 0f4cfcb 
> 
> Diff: http://git.reviewboard.kde.org/r/108527/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Niko Sams
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130121/8edb550b/attachment.html>


More information about the KDevelop-devel mailing list