Review Request 108482: Title bar now correctly updades after Open/Import or Close Project

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108482/#review25785
-----------------------------------------------------------



interfaces/isession.h
<http://git.reviewboard.kde.org/r/108482/#comment19698>

    Why did you need to add this as public API? The only caller lives in shell so it can use the functions of Session after a cast, no need to make this public and callable by plugins.



shell/projectcontroller.cpp
<http://git.reviewboard.kde.org/r/108482/#comment19699>

    Hmm, instead of this explicit updating, why not let Session or SessionController connect to the project controllers signals to get notified about added/removed projects. IIRC the text in the menu also needs to be updated.



shell/session.h
<http://git.reviewboard.kde.org/r/108482/#comment19704>

    unrelated change.



shell/session.h
<http://git.reviewboard.kde.org/r/108482/#comment19701>

    unrelated whitespace change



shell/session.h
<http://git.reviewboard.kde.org/r/108482/#comment19700>

    unrelated whitespace change.



shell/session.h
<http://git.reviewboard.kde.org/r/108482/#comment19702>

    unrelated whitespace change



shell/session.h
<http://git.reviewboard.kde.org/r/108482/#comment19703>

    unrelated change


- Andreas Pakulat


On Jan. 19, 2013, 9:32 a.m., Lambert CLARA wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108482/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2013, 9:32 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> On a newly created session, the mainwindow name remained at (no projects) after an Open/Import project, and was not updated when a project was closed.
> If kdevelop was opened with an already existing session, the title bar was ok.
> 
> This was due to the SessionInfo's project list, which was not updated when loading/closing a project. However, the config group was, explaining why it worked at reboot.
> 
> 
> Diffs
> -----
> 
>   interfaces/isession.h 6a1c523 
>   shell/projectcontroller.cpp aba9156 
>   shell/session.h d47ec41 
>   shell/session.cpp a59d70e 
> 
> Diff: http://git.reviewboard.kde.org/r/108482/diff/
> 
> 
> Testing
> -------
> 
> Open/Import multiple projects on a newly created session, and close them. Open multiple instances of kdevelop and do the same.
> Launch ctest, 100% tests passed, 0 tests failed out of 43.
> 
> 
> Thanks,
> 
> Lambert CLARA
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130119/1e540b1c/attachment.html>