Review Request: ProjectProxyModel: show real filtered item count

[Milian Wolff]

> On Jan. 5, 2013, 9:48 p.m., Andreas Pakulat wrote:
> > Personally I find this number completely useless. Why would anyone want to know how many files are shown? I'd rather want to see how many are hidden and then you wouldn't have this problem.
> > 
> > Apart from that I don't think sacrificing the performance in such a drastic way is worth it, especially not when people still haveproblems loading the kernel sources due to the projectsize.

+1 I also think the *hidden* files should be counted, not the shown ones. And such a pessimization is certainly not a good idea at all.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108210/#review24778
-----------------------------------------------------------


On Jan. 5, 2013, 8:59 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108210/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2013, 8:59 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> When a project model filter is enabled, the ProjectProxyModel alters folder names to show count of items that match the filter.
> Currently, these counts also include non-matched folders, because folders are not subject to filtering and the counts are calculated using rowCount(), so they are effectively pointless for tasks of evaluating how many matched files reside in some folder.
> 
> This patch makes these counts "real" by walking the model once again and counting actual files under the given folder. Unfortunately this changes complexity of model rendering to O(n^2)...
> 
> 
> Diffs
> -----
> 
>   project/projectproxymodel.h 279389b 
>   project/projectproxymodel.cpp 5da4f6c 
> 
> Diff: http://git.reviewboard.kde.org/r/108210/diff/
> 
> 
> Testing
> -------
> 
> Existing unit-tests and manual testing.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130106/4d6032ac/attachment-0001.html>