Review Request: Properly strip HTML from assistants' title and action descriptions when converting them to KAction/QMenu.

[Milian Wolff]

> On Jan. 6, 2013, 8:34 a.m., Andreas Pakulat wrote:
> > I had to revert this commit since it broke the build and needs a different solution. The removeHtmlFromString function cannot be in another library and be used from interfaces since that one can only link against KDE/Qt and other third-party libs not against any kdevplatform libs. So either the code using removeHtmlFromString needs to be moved out of iassistant.cpp or the function needs to be moved into the interfaces library and be used from there. No idea whats cleaner from an API pov.

What about moving that assistant stuff to language/interfaces? 


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108146/#review24793
-----------------------------------------------------------


On Jan. 4, 2013, 5:48 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108146/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2013, 5:48 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Fix HTML -> plaintext conversion when converting assistants to KAction/QMenu. This fixes at least one visible case - invoking context menu on a problem with missing declaration assistant.
> 
> 
> Diffs
> -----
> 
>   interfaces/iassistant.cpp 8d433a3 
>   plugins/problemreporter/problemreporterplugin.cpp 27e41ee 
>   util/formattinghelpers.h d82d421 
>   util/formattinghelpers.cpp b646068 
> 
> Diff: http://git.reviewboard.kde.org/r/108146/diff/
> 
> 
> Testing
> -------
> 
> Apparently works.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130106/acdb8631/attachment.html>