Review Request: [1/3] Refactor EnvironmentSelectionWidget.
Ivan Shapovalov
intelfx100 at gmail.com
Sat Jan 5 21:22:09 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108212/
-----------------------------------------------------------
Review request for KDevelop.
Description
-------
Feature-wise this gets rid of dependency on default KConfigXT value being "default" and allows explicitly specifying to use a default environment group whatever it will be.
Now an empty value shall be used by default, which has meaning of "use whatever is set by default at runtime".
Also, a special "Use default" line is now always added to the combo-box which maps to the empty config value, so user won't see empty entries in the combo-box.
Diffs
-----
plugins/execute/nativeappconfig.cpp 481d56c
plugins/executescript/scriptappconfig.cpp b8f0729
util/CMakeLists.txt 29de126
util/environmentconfigurebutton.cpp 8303c70
util/environmentselectionmodel.h PRE-CREATION
util/environmentselectionmodel.cpp PRE-CREATION
util/environmentselectionwidget.h 0a69afc
util/environmentselectionwidget.cpp 63fdebc
Diff: http://git.reviewboard.kde.org/r/108212/diff/
Testing
-------
Manual testing.
Thanks,
Ivan Shapovalov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130105/33f5f3b2/attachment-0001.html>
More information about the KDevelop-devel
mailing list