Review Request: Properly strip HTML from assistants' title and action descriptions when converting them to KAction/QMenu.

Milian Wolff mail at milianw.de
Fri Jan 4 13:16:15 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108146/#review24660
-----------------------------------------------------------



plugins/problemreporter/problemreporterplugin.cpp
<http://git.reviewboard.kde.org/r/108146/#comment18919>

    this code should be shared somehow, maybe put it into kdevplatform/util somewhere?


- Milian Wolff


On Jan. 3, 2013, 9:56 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108146/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2013, 9:56 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Fix HTML -> plaintext conversion when converting assistants to KAction/QMenu. This fixes at least one visible case - invoking context menu on a problem with missing declaration assistant.
> 
> 
> Diffs
> -----
> 
>   interfaces/iassistant.cpp 8d433a3 
>   plugins/problemreporter/problemreporterplugin.cpp 27e41ee 
> 
> Diff: http://git.reviewboard.kde.org/r/108146/diff/
> 
> 
> Testing
> -------
> 
> Apparently works.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130104/86c7301c/attachment.html>


More information about the KDevelop-devel mailing list