Review Request 104574: Memory viewer fixes.

[Ben Wagner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104574/
-----------------------------------------------------------

(Updated Feb. 16, 2013, 6:56 a.m.)


Review request for KDevelop, Kevin Funk, Milian Wolff, and Niko Sams.


Changes
-------

Adding reviewers who seem to be more active at the moment and have previously commented on this review.


Description
-------

This now (diff r2) brings back the memory viewer in a workable state. I think this is about as good as it gets with a KHexView. It would be nice to use Okteta instead of KHexView, but that would make a great next implementation. The gdb calls have been fixed and no longer cause random and frequent crashes (which is why the tool was disabled to begin with).


This addresses bugs 172621 and 256044.
    http://bugs.kde.org/show_bug.cgi?id=172621
    http://bugs.kde.org/show_bug.cgi?id=256044


Diffs
-----

  debuggers/gdb/CMakeLists.txt 021ea33 
  debuggers/gdb/debuggerplugin.h fe12ddd 
  debuggers/gdb/debuggerplugin.cpp d499af1 
  debuggers/gdb/memviewdlg.h 1629cd0 
  debuggers/gdb/memviewdlg.cpp 0500a21 

Diff: http://git.reviewboard.kde.org/r/104574/diff/


Testing
-------

Got it working. Used it (and have been using it now for a while). When Okteta is installed it works and I haven't gotten it to crash again yet.


File Attachments
----------------

git format-patch
  http://git.reviewboard.kde.org/media/uploaded/files/2013/02/07/0001-Improve-and-re-enable-memory-tool-view.patch


Thanks,

Ben Wagner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130216/e889268f/attachment.html>