Review Request 108943: List project names in matches

Sebastian Kügler sebas at kde.org
Wed Feb 13 23:53:12 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108943/#review27414
-----------------------------------------------------------

Ship it!


Thanks for the patch, and maybe even more so for cleaning up the code in a few places. I'm actually a bit embarrassed how dirty it looks like in places. :/

When Milian is happy, I am. :)


app/plasma/runner/kdevelopsessions.cpp
<http://git.reviewboard.kde.org/r/108943/#comment20634>

    Could you remove this one, as you're editing that file anyway?


- Sebastian Kügler


On Feb. 13, 2013, 5:08 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108943/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 5:08 p.m.)
> 
> 
> Review request for KDevelop and Sebastian Kügler.
> 
> 
> Description
> -------
> 
> List project names in matches
> 
> This is useful when one does not take the time to give name to KDevelop
> sessions.
> 
> 
> Diffs
> -----
> 
>   app/plasma/runner/kdevelopsessions.h eb85da9825d5c8bf1db02b082738ae82a7acc108 
>   app/plasma/runner/kdevelopsessions.cpp a1755379ca9fea8144c211b63c3b1a912263ecc6 
> 
> Diff: http://git.reviewboard.kde.org/r/108943/diff/
> 
> 
> Testing
> -------
> 
> Tested with krunner and homerun
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130213/79d7a596/attachment.html>


More information about the KDevelop-devel mailing list