Review Request 108943: List project names in matches

[Aurélien Gâteau]

> On Feb. 13, 2013, 5:25 p.m., Milian Wolff wrote:
> > app/plasma/runner/kdevelopsessions.h, line 27
> > <http://git.reviewboard.kde.org/r/108943/diff/1/?file=113936#file113936line27>
> >
> >     mark this type as movable please
> 
> Aurélien Gâteau wrote:
>     I am afraid I don't know what "mark as movable" means.
> 
> Milian Wolff wrote:
>     Q_DECLARE_METATYPE(Session, Q_MOVABLE_TYPE);

I just read the doc about this. It says "Q_MOVABLE_TYPE specifies that Type has a constructor and/or a destructor but can be moved in memory using memcpy().". Are you sure one can copy QStrings with memcpy()?


> On Feb. 13, 2013, 5:25 p.m., Milian Wolff wrote:
> > app/plasma/runner/kdevelopsessions.h, line 29
> > <http://git.reviewboard.kde.org/r/108943/diff/1/?file=113936#file113936line29>
> >
> >     hash? you mean id - or?
> 
> Aurélien Gâteau wrote:
>     `kdevelop --help` says --open-session argument can be either the hash or the name of the session. I figured the "{f3fcd46e-2843-447e-87e9-21a81504d6ba}" was the session hash. What should it be named?
> 
> Milian Wolff wrote:
>     We should also talk about ID in the --help output - thats what this hash represents.

OK, will fix.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108943/#review27382
-----------------------------------------------------------


On Feb. 13, 2013, 6:08 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108943/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 6:08 p.m.)
> 
> 
> Review request for KDevelop and Sebastian Kügler.
> 
> 
> Description
> -------
> 
> List project names in matches
> 
> This is useful when one does not take the time to give name to KDevelop
> sessions.
> 
> 
> Diffs
> -----
> 
>   app/plasma/runner/kdevelopsessions.h eb85da9825d5c8bf1db02b082738ae82a7acc108 
>   app/plasma/runner/kdevelopsessions.cpp a1755379ca9fea8144c211b63c3b1a912263ecc6 
> 
> Diff: http://git.reviewboard.kde.org/r/108943/diff/
> 
> 
> Testing
> -------
> 
> Tested with krunner and homerun
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130213/4c0abcd8/attachment-0001.html>