Milian Wolff mail at milianw.de
Wed Feb 13 22:19:24 UTC 2013

On Wednesday 13 February 2013 23:15:39 Milian Wolff wrote:
> Hey Aleix,
> what did you intend to fix with OutputModel::flushLineBuffer?
> Why was this required? It looks very wrong to me as it breaks the whole
> batching idea (and was also removed because of this in our
> wip/filter_output_threaded branch).
> I can only see it being used in the CTestRunJob but without any comment
> indicating *why* its being used there.

Also removeLastLines - why is that required there? To quote Andreas:

    Removes 'removeLastLines' since the only user was the ninja-plugin and 
    one should handle its special needs in its own code instead of requiring
    API changes that nobody else needs.
    Removes 'flushLineBuffer' since the idea of that function goes completely
    against the idea of doing batches in the first place so it shouldn't 
    If code needs to know when all items are available in the model it'll have
    to connect to the model signals and verify wether the number of lines in
    the model matches the expected final amount. This function is used in the
    ctest-related code in kdevelop, so will need a change there too.

Milian Wolff
mail at milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130213/6c437e3c/attachment-0001.sig>

More information about the KDevelop-devel mailing list