Review Request 108943: List project names in matches

Milian Wolff mail at milianw.de
Wed Feb 13 16:25:55 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108943/#review27382
-----------------------------------------------------------



app/plasma/runner/kdevelopsessions.h
<http://git.reviewboard.kde.org/r/108943/#comment20610>

    mark this type as movable please



app/plasma/runner/kdevelopsessions.h
<http://git.reviewboard.kde.org/r/108943/#comment20608>

    hash? you mean id - or?



app/plasma/runner/kdevelopsessions.h
<http://git.reviewboard.kde.org/r/108943/#comment20609>

    make it a vector



app/plasma/runner/kdevelopsessions.cpp
<http://git.reviewboard.kde.org/r/108943/#comment20612>

    whitespaces around == please



app/plasma/runner/kdevelopsessions.cpp
<http://git.reviewboard.kde.org/r/108943/#comment20611>

    id


- Milian Wolff


On Feb. 13, 2013, 4:13 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108943/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 4:13 p.m.)
> 
> 
> Review request for KDevelop and Sebastian Kügler.
> 
> 
> Description
> -------
> 
> List project names in matches
> 
> This is useful when one does not take the time to give name to KDevelop
> sessions.
> 
> 
> Diffs
> -----
> 
>   app/plasma/runner/kdevelopsessions.h eb85da9 
>   app/plasma/runner/kdevelopsessions.cpp a175537 
> 
> Diff: http://git.reviewboard.kde.org/r/108943/diff/
> 
> 
> Testing
> -------
> 
> Tested with krunner and homerun
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130213/a635518f/attachment.html>


More information about the KDevelop-devel mailing list