Review Request 108872: Use correct Yes/No items in "could not find editor" dialog.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108872/#review27168
-----------------------------------------------------------


This review has been submitted with commit 00f33f21d1d26c7d62ef9aa0cef4c8676d7af43c by Miha Čančula to branch 1.5.

- Commit Hook


On Feb. 9, 2013, 10:21 a.m., Miha Čančula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108872/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2013, 10:21 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> When KDevelop cannot find a editor for a file, it asks whether to open it as plain text. However, clicking "No" causes it to be openend, while "Yes" cancels the whole thing. This is caused because the arguments to KMessageBox::questionYesNo() are passed in the wrong order. 
> 
> I just switched the order, so Yes means yes and No means no. However, it might be better to use full verbs ("Open as plain text", "Don't open") instead. 
> 
> This should also be backported into 1.5. 
> 
> 
> Diffs
> -----
> 
>   shell/documentcontroller.cpp 62fab2e 
> 
> Diff: http://git.reviewboard.kde.org/r/108872/diff/
> 
> 
> Testing
> -------
> 
> Tested locally, it's really a small change. 
> 
> 
> Thanks,
> 
> Miha Čančula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130211/f0d06121/attachment.html>