Review Request 108848: Fix parenting in BuilderJob::addSubjob()

Aleix Pol Gonzalez aleixpol at gmail.com
Fri Feb 8 11:19:01 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108848/#review26950
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Feb. 8, 2013, 10:34 a.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108848/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2013, 10:34 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Fix parenting in BuilderJob::addSubjob()
> 
> Fixes a bug in kdelibs, which is fixed in KDE 4.11.
> At this point we can easily work-around this issue.
> See cc'ed bug for explanation(s).
> 
> This fixes a crash-on-exit with a build running.
> 
> CCBUG: 230692
> 
> 
> This addresses bug 230692.
>     http://bugs.kde.org/show_bug.cgi?id=230692
> 
> 
> Diffs
> -----
> 
>   project/builderjob.h a6eaf30c2224793911b6a01f94a55812944f36c0 
>   project/builderjob.cpp 0eeebf7fab8208daf5500043acd2d51b424cf9a4 
> 
> Diff: http://git.reviewboard.kde.org/r/108848/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130208/665e2fe5/attachment-0001.html>


More information about the KDevelop-devel mailing list