Review Request 108814: Add SOURCES to add_custom_target.

[Ben Wagner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108814/
-----------------------------------------------------------

(Updated Feb. 7, 2013, 11:34 p.m.)


Review request for KDevelop.


Changes
-------

Noting that I'm not a committer in the description.


Description (updated)
-------

Add SOURCES to add_custom_target. For some time now (at least since 2.6), add_custom_target has a SOURCES section with the documentation at http://www.cmake.org/cmake/help/cmake2.6docs.html#command:add_custom_target stating "The SOURCES option specifies additional source files to be included in the custom target. Specified source files will be added to IDE project files for convenience in editing even if they have not build rules." Support for this seems to be missing, this patch adds it.

Note that I cannot commit this myself, so someone else will need to push these patches.


Diffs
-----

  projectmanagers/cmake/parser/cmakeast.h 9f89c87 
  projectmanagers/cmake/parser/cmakeast.cpp 74bfd04 
  projectmanagers/cmake/parser/cmakeprojectvisitor.cpp 547adc1 

Diff: http://git.reviewboard.kde.org/r/108814/diff/


Testing
-------

Built, run, observed change.


File Attachments
----------------

git format-patch
  http://git.reviewboard.kde.org/media/uploaded/files/2013/02/06/0001-Add-SOURCES-to-add_custom_target.patch
test
  http://git.reviewboard.kde.org/media/uploaded/files/2013/02/07/0002-Add-test-for-add_custom_target-SOURCES.patch


Thanks,

Ben Wagner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130207/ed76389e/attachment.html>