Review Request 108694: Fix another crash-on-exit

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108694/#review26487
-----------------------------------------------------------


Gah. Ignore the first two hungs in builderjob.(cpp|h). The post-review script picked up too many changes again. I blame the tools.

- Kevin Funk


On Jan. 31, 2013, 11:42 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108694/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2013, 11:42 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Fix another crash-on-exit
> 
> Easily reproducable:
> * Load project, wait for it to load
> * Change CMakeLists.txt, do not save
> * Build project
> * Immediately close KDevelop
> 
> Backtrace (reduced):
> 5  0x00007f5f092b7345 in KDevelop::ProjectBaseItem::appendRow
> (this=0x2425560, item=0x67255a0) at
> /home/krf/devel/src/kdevplatform/project/projectmodel.cpp:421
> 6  0x00007f5f0ec4dad2 in KDevelop::ProjectPrivate::reloadDone
> (this=0x5f0d2b0) at
> /home/krf/devel/src/kdevplatform/shell/project.cpp:160
> 
> The hunk in void Project::close() fixes a consecutive crash:
> #10 0x00007f72feb6faac in qt_assert (assertion=0x7f72faba5538 "row >= 0 && row < d->children.size()", file=0x7f72faba52d0 "/home/krf/devel/src/kdevplatform/project/projectmodel.cpp", line=199) at /home/krf/devel/src/qt/src/corelib/global/qglobal.cpp:2018
> #11 0x00007f72fab8e4b4 in KDevelop::ProjectBaseItem::takeRow (this=0x25ed8c0, row=-1) at /home/krf/devel/src/kdevplatform/project/projectmodel.cpp:199
> #12 0x00007f72fab8e9c9 in KDevelop::ProjectBaseItem::removeRow (this=<optimized out>, row=<optimized out>) at /home/krf/devel/src/kdevplatform/project/projectmodel.cpp:222
> #13 0x00007f7300522b28 in KDevelop::Project::close (this=0x4dced40) at /home/krf/devel/src/kdevplatform/shell/project.cpp:555
> #14 0x00007f730051c6a4 in KDevelop::ProjectController::closeProject (this=0x25ee860, proj_=<optimized out>) at /home/krf/devel/src/kdevplatform/shell/projectcontroller.cpp:869
> 
> 
> Diffs
> -----
> 
>   project/builderjob.h 4acbdef8e19728fd762928bc5a41b852c4468436 
>   project/builderjob.cpp 24f128d02c2da2242a0539622c2e8de95a1dc30f 
>   shell/project.h eb56db521697330e3e05bd39884790789f469138 
>   shell/project.cpp a145604a818437d13572f64847781640392364d8 
> 
> Diff: http://git.reviewboard.kde.org/r/108694/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130201/d53c050d/attachment-0001.html>