Review Request 114753: RFC: Dynamic layouts for some tool view widgets

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114753/
-----------------------------------------------------------

Review request for KDevelop.


Repository: kdevplatform


Description
-------

RFC: Dynamic layouts for some tool view widgets

Support added for the break point and frame stack widget for now.

My first idea was to add API to KDevelop::IToolViewFactory and friends in order to support something like dynamic layouts in the tool views. But then I thought: We can have this much easier -- just let the *widget* contained in the dock decide how to layout its children and don't even touch the glue code for tool views.

Comments?


Diffs
-----

  debugger/breakpoint/breakpointwidget.h c5f3f6b6cc92385c9e07e5c4ceb185db15817edd 
  debugger/breakpoint/breakpointwidget.cpp d180181e2306c9aa8c6f8b596d84857f3acb1ba3 
  debugger/framestack/framestackwidget.h 60d4a155b4ba0edaa63375f22ab3cff1f12fca9c 
  debugger/framestack/framestackwidget.cpp d339472e8464933e5b2fb5048cb73ce54e881e95 

Diff: https://git.reviewboard.kde.org/r/114753/diff/


Testing
-------


File Attachments
----------------

kdevelop-dynamic-layouts_before.png
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/31/0585b34d-c2d5-4093-807d-e912fd5dff35__kdevelop-dynamic-layouts_before.png
kdevelop-dynamic-layouts_after.png
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/31/19b3b1a5-25b8-4997-b0b0-61c2f3b2421a__kdevelop-dynamic-layouts_after.png


Thanks,

Kevin Funk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131231/deb2dbd8/attachment.html>