Review Request 103485: patch to add support for C++11 user defined string literals to kdevelop background parser

Milian Wolff mail at milianw.de
Sun Dec 29 13:33:29 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/103485/#review46377
-----------------------------------------------------------


Please undo the unrelated changeset and add unit tests for this in test_parser.h/test_parser_cpp2011.cpp

Thanks!

- Milian Wolff


On Dec. 28, 2013, 9:32 p.m., François-Marie de Jouvencel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/103485/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2013, 9:32 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 302510
>     http://bugs.kde.org/show_bug.cgi?id=302510
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This is to add support for C++11 user defined string literals (that is, strings like "hello"_world) to the kdevelop background parser. The patch consists of just a few lines in lexer.cpp.
> 
> 
> Diffs
> -----
> 
>   kdevelop.kdev4 023bd89 
>   languages/cpp/parser/lexer.cpp 755b5ab 
> 
> Diff: https://git.reviewboard.kde.org/r/103485/diff/
> 
> 
> Testing
> -------
> 
> I have been using the patch since a day or two and I did not notice anything broken.
> 
> 
> Thanks,
> 
> François-Marie de Jouvencel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131229/8143b8fe/attachment.html>


More information about the KDevelop-devel mailing list