Review Request 114579: Don't Build QtHelp Plugin when QtHelp is not Installed

Aleix Pol Gonzalez aleixpol at kde.org
Mon Dec 23 01:43:27 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114579/#review46060
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Dec. 22, 2013, 4:40 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114579/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2013, 4:40 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Find out if QtHelp is installed and decide whether to build the qthelp plugin or not. Also log the feature.
> 
> 
> Diffs
> -----
> 
>   documentation/CMakeLists.txt 5227063 
> 
> Diff: https://git.reviewboard.kde.org/r/114579/diff/
> 
> 
> Testing
> -------
> 
> 1. Tried building without QtHelp
>  1.1 Before this patch, build failed in qthelp directory
>  1.2 After this patch, build does not fail, qthelp plugin is not built
> 2. Tried building with QtHelp, builds OK
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131223/5a4d2aec/attachment.html>


More information about the KDevelop-devel mailing list