Review Request 114579: Don't Build QtHelp Plugin when QtHelp is not Installed

[David Narváez]

> On Dec. 21, 2013, 12:02 a.m., Kevin Funk wrote:
> > CMakeLists.txt, line 36
> > <http://git.reviewboard.kde.org/r/114579/diff/1/?file=226752#file226752line36>
> >
> >     You don't need another call to find_package for Qt4 in order have QT_QTHELP_FOUND set. In fact, OPTIONAL_COMPONENTS is not even a valid parameter anyway, afaics.
> 
> David Narváez wrote:
>     I just tried removing the call to find_package(Qt4...) and now QtHelp was not found. I then purged and tried again and QtHep was not found. My CMake version is 2.8.12.1 and OPTIONAL_COMPONENTS seems to be there since CMake 2.8.8-rc1.
> 
> Kevin Funk wrote:
>     This is odd. I just verified that it works for me. Simply putting 'message(STATUS "${QT_QTHELP_FOUND}")' into documentation/CMakeLists.txt prints out "1". I then removed QtHelp*so and the include dir from my Qt4 install. Re-running cmake in KDevelop then correctly prints out "" only.
>     
>     Btw, OPTIONAL_COMPONENTS is not used anywhere in KDevelop -- QJSON_FOUND is used similarly as I proposed initially (no extra find_package call, etc.). So it should definitely work.
>     
>     Can you check if you're missing something?

Do you mean this in languages/cpp/tests/CMakeLists.txt?

find_package(QJSON)
# Also check that kdevplatform is built with JSON support
# see: https://bugs.kde.org/show_bug.cgi?id=327095
if(QJSON_FOUND AND KDEVPLATFORM_JSONTESTS_LIBRARIES)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114579/#review45972
-----------------------------------------------------------


On Dec. 20, 2013, 10:51 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114579/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2013, 10:51 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Find out if QtHelp is installed and decide whether to build the qthelp plugin or not. Also log the feature.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt cd5feec 
>   documentation/CMakeLists.txt 5227063 
> 
> Diff: http://git.reviewboard.kde.org/r/114579/diff/
> 
> 
> Testing
> -------
> 
> 1. Tried building without QtHelp
>  1.1 Before this patch, build failed in qthelp directory
>  1.2 After this patch, build does not fail, qthelp plugin is not built
> 2. Tried building with QtHelp, builds OK
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131222/6507df69/attachment-0001.html>