Review Request 114579: Don't Build QtHelp Plugin when QtHelp is not Installed

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114579/#review45972
-----------------------------------------------------------


Please move the macro_log_feature call to documentation/CMakeLists.txt. Seems to be consistent with the rest of the KDevelop codebase (to have those calls as close as possible to the use).


CMakeLists.txt
<http://git.reviewboard.kde.org/r/114579/#comment32805>

    You don't need another call to find_package for Qt4 in order have QT_QTHELP_FOUND set. In fact, OPTIONAL_COMPONENTS is not even a valid parameter anyway, afaics.



documentation/CMakeLists.txt
<http://git.reviewboard.kde.org/r/114579/#comment32806>

    endif() is sufficient nowadays.


Rest looks fine, you can commit after having fixed the issues.

- Kevin Funk


On Dec. 20, 2013, 10:51 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114579/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2013, 10:51 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Find out if QtHelp is installed and decide whether to build the qthelp plugin or not. Also log the feature.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt cd5feec 
>   documentation/CMakeLists.txt 5227063 
> 
> Diff: http://git.reviewboard.kde.org/r/114579/diff/
> 
> 
> Testing
> -------
> 
> 1. Tried building without QtHelp
>  1.1 Before this patch, build failed in qthelp directory
>  1.2 After this patch, build does not fail, qthelp plugin is not built
> 2. Tried building with QtHelp, builds OK
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131221/de2fc44a/attachment.html>