Review Request 114466: Remove noisy compiler warnings

[lycantrophe li]

> On Dec. 15, 2013, 11:13 p.m., Milian Wolff wrote:
> > projectmanagers/custom-buildsystem/custombuildsystemconfigwidget.cpp, line 239
> > <http://git.reviewboard.kde.org/r/114466/diff/2/?file=225029#file225029line239>
> >
> >     yeah, it could be removed thus cleaning up the code.
> 
> lycantrophe li wrote:
>     In the case of configurationsSelected I can agree, as the variable itself is about as long as the actual check, and as it is easy to see what's going on.

Diff rev.6 implements this, but I'm not sure if it actually is an improvement. I split it into its own commit so it would be easier to (not) merge.


- lycantrophe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114466/#review45739
-----------------------------------------------------------


On Dec. 16, 2013, 10:59 a.m., lycantrophe li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114466/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 10:59 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: Warnings
>     http://bugs.kde.org/show_bug.cgi?id=Warnings
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Some small fixes that removes some compiler warnings.
> 
> Some warnings only appear when building for release when asserts gets defined or optimized outs, leaving variables passed to them unused. Commit 97f5869 explicitly flags some of these with Q_UNUSED silencing the warning and telling contributers that it is only there to make reading and asserting easier.
> 
> Commit 5a4f06a silences some virtual-overload compiler warnings by explicitly saying that we want the parent's visit-methods available. This is augmented by adding the override identifier to the overriden methods, which is consistent with the transition to C++11.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/custom-buildsystem/custombuildsystemconfigwidget.cpp 042d523 
> 
> Diff: http://git.reviewboard.kde.org/r/114466/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests. 97f5869 does not alter any code that does work. 5a4f06a only makes explicit what used to be implicit.
> 
> 
> Thanks,
> 
> lycantrophe li
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131216/1a6ba550/attachment-0001.html>