Review Request 114466: Remove noisy compiler warnings

[lycantrophe li]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114466/
-----------------------------------------------------------

(Updated Dec. 16, 2013, 10:55 a.m.)


Review request for KDevelop.


Changes
-------

Right, I failed with the review-board and made gave review 4 a parent. This, however, implements all the changes from #1, but with the additions outlined in the comments.


Bugs: Warnings
    http://bugs.kde.org/show_bug.cgi?id=Warnings


Repository: kdevelop


Description
-------

Some small fixes that removes some compiler warnings.

Some warnings only appear when building for release when asserts gets defined or optimized outs, leaving variables passed to them unused. Commit 97f5869 explicitly flags some of these with Q_UNUSED silencing the warning and telling contributers that it is only there to make reading and asserting easier.

Commit 5a4f06a silences some virtual-overload compiler warnings by explicitly saying that we want the parent's visit-methods available. This is augmented by adding the override identifier to the overriden methods, which is consistent with the transition to C++11.


Diffs (updated)
-----

  languages/cpp/cppduchain/cppducontext.h fdbe165 
  languages/cpp/cppduchain/templatedeclaration.cpp 6b48b7a 
  projectmanagers/cmake/cmakeutils.cpp 9aa22ca 
  projectmanagers/cmake/tests/testhelpers.h 5cf552c 
  projectmanagers/custom-buildsystem/custombuildsystemconfigwidget.cpp 042d523 

Diff: http://git.reviewboard.kde.org/r/114466/diff/


Testing
-------

Ran unit tests. 97f5869 does not alter any code that does work. 5a4f06a only makes explicit what used to be implicit.


Thanks,

lycantrophe li

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131216/c3e5d80d/attachment.html>