Review Request 114421: Fix binary operations on unsure types.

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114421/#review45618
-----------------------------------------------------------


Huh reviewboard at my text...
Good patch, the code flow and functionality should be fine, I just have some mostly stylistic complaints. It's a lot of issues but they're all trivial.

- Sven Brauch


On Dec. 12, 2013, 8:07 p.m., Levente Kurusa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114421/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2013, 8:07 p.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> This patch is a GCI task.
> 
> http://www.google-melange.com/gci/task/view/google/gci2013/5282511542288384
> 
> 
> Diffs
> -----
> 
>   duchain/expressionvisitor.h 31c6afb 
>   duchain/expressionvisitor.cpp 082f895 
>   duchain/tests/pyduchaintest.h 0b6413b 
>   duchain/tests/pyduchaintest.cpp 5f67716 
> 
> Diff: http://git.reviewboard.kde.org/r/114421/diff/
> 
> 
> Testing
> -------
> 
> Attached unit tests all pass.
> 
> 
> Thanks,
> 
> Levente Kurusa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131212/d6a69fa6/attachment.html>