Review Request 114323: Clean up session description handling.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114323/#review45602
-----------------------------------------------------------



shell/projectcontroller.cpp
<http://git.reviewboard.kde.org/r/114323/#comment32535>

    while at it, please reserve size of m_projects



shell/session.h
<http://git.reviewboard.kde.org/r/114323/#comment32538>

    signal/slot parametesr should be fully qualified, i.e. KDevelop::Session. Also, why not move that signal to ISession?



shell/session.cpp
<http://git.reviewboard.kde.org/r/114323/#comment32542>

    this newline could be removed imo.



shell/session.cpp
<http://git.reviewboard.kde.org/r/114323/#comment32534>

    -class



shell/session.cpp
<http://git.reviewboard.kde.org/r/114323/#comment32536>

    should this not be handled by generatePrettyContents?



shell/sessioncontroller.cpp
<http://git.reviewboard.kde.org/r/114323/#comment32541>

    fully qualified



shell/sessioncontroller.cpp
<http://git.reviewboard.kde.org/r/114323/#comment32540>

    fully qualified



shell/tests/sessioncontrollertest.cpp
<http://git.reviewboard.kde.org/r/114323/#comment32537>

    both of these should go to the respective headers, i.e. the isession.h and session.h files



shell/tests/sessioncontrollertest.cpp
<http://git.reviewboard.kde.org/r/114323/#comment32539>

    fully qualified please


- Milian Wolff


On Dec. 6, 2013, 5:54 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114323/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2013, 5:54 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This fixes session list and window title not reflecting actual session data (name and project list).
> 
> Things done:
> 1) project list is written to the session via a new interface method (ISession::setContainedProjects()) instead of directly writing to the session's config
> 2) signal Session::nameChanged() is replaced by Session::sessionUpdated(), which is called on both name change and project list change
> 3) anything that displays session contents now listens only to that signal instead of nameChanged()+projectOpened()+projectClosed()
> 
> 
> Diffs
> -----
> 
>   interfaces/isession.h d96695d 
>   shell/mainwindow.cpp ddb07f5 
>   shell/projectcontroller.cpp ee89dd7 
>   shell/session.h 0154156 
>   shell/session.cpp 9fdd31f 
>   shell/sessioncontroller.h 1986360 
>   shell/sessioncontroller.cpp 3be453e 
>   shell/tests/sessioncontrollertest.cpp d7e9093 
> 
> Diff: http://git.reviewboard.kde.org/r/114323/diff/
> 
> 
> Testing
> -------
> 
> Works as expected and unit-tests pass.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131212/e339ec0b/attachment-0001.html>