Review Request 108212: [1/3] Refactor EnvironmentSelectionWidget.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108212/#review45254
-----------------------------------------------------------



util/environmentselectionmodel.h
<http://git.reviewboard.kde.org/r/108212/#comment32332>

    const



util/environmentselectionmodel.cpp
<http://git.reviewboard.kde.org/r/108212/#comment32333>

    ah so here you use this... but why? Don't do the compilers work, just write this:
    
    m_env = EnvironmentGroupList( KGlobal::config() );



util/environmentselectionwidget.cpp
<http://git.reviewboard.kde.org/r/108212/#comment32335>

    return d->model->index( ... ).data( Qt::EditRole ).toString();



util/environmentselectionwidget.cpp
<http://git.reviewboard.kde.org/r/108212/#comment32334>

    return d->model->index( d->comboBox->currentIndex(), 0 ).data( ... ).toString();


- Milian Wolff


On Dec. 6, 2013, 5:15 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108212/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2013, 5:15 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Feature-wise this gets rid of dependency on default KConfigXT value being "default" and allows explicitly specifying to use a default environment group whatever it will be.
> 
> Now an empty value shall be used by default, which has meaning of "use whatever is set by default at runtime".
> Also, a special "Use default" line is now always added to the combo-box which maps to the empty config value, so user won't see empty entries in the combo-box.
> 
> 
> Diffs
> -----
> 
>   plugins/execute/nativeappconfig.cpp 6f2dd8c 
>   plugins/executescript/scriptappconfig.cpp 370231a 
>   util/CMakeLists.txt 5bf1255 
>   util/environmentconfigurebutton.cpp b95e536 
>   util/environmentgrouplist.h 4981b73 
>   util/environmentgrouplist.cpp cec71bd 
>   util/environmentselectionmodel.h PRE-CREATION 
>   util/environmentselectionmodel.cpp PRE-CREATION 
>   util/environmentselectionwidget.h 0784ba1 
>   util/environmentselectionwidget.cpp a198f32 
> 
> Diff: http://git.reviewboard.kde.org/r/108212/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131206/4656cb14/attachment.html>