Review Request 108212: [1/3] Refactor EnvironmentSelectionWidget.

[Ivan Shapovalov]

> On Dec. 5, 2013, 1:25 p.m., Milian Wolff wrote:
> > util/environmentselectionmodel.h, line 45
> > <http://git.reviewboard.kde.org/r/108212/diff/4/?file=222542#file222542line45>
> >
> >     you should probably also implement header data and give proper titles to the columns

We subclass QStringListModel, there is only one column (profile name).


> On Dec. 5, 2013, 1:25 p.m., Milian Wolff wrote:
> > util/environmentselectionwidget.cpp, line 31
> > <http://git.reviewboard.kde.org/r/108212/diff/4/?file=222545#file222545line31>
> >
> >     that looks wrong

This is for placement new.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108212/#review45191
-----------------------------------------------------------


On Dec. 4, 2013, 4:02 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108212/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2013, 4:02 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Feature-wise this gets rid of dependency on default KConfigXT value being "default" and allows explicitly specifying to use a default environment group whatever it will be.
> 
> Now an empty value shall be used by default, which has meaning of "use whatever is set by default at runtime".
> Also, a special "Use default" line is now always added to the combo-box which maps to the empty config value, so user won't see empty entries in the combo-box.
> 
> 
> Diffs
> -----
> 
>   plugins/execute/nativeappconfig.cpp 6f2dd8c 
>   plugins/executescript/scriptappconfig.cpp 370231a 
>   util/CMakeLists.txt 87384bd 
>   util/environmentconfigurebutton.cpp b95e536 
>   util/environmentselectionmodel.h PRE-CREATION 
>   util/environmentselectionmodel.cpp PRE-CREATION 
>   util/environmentselectionwidget.h 0784ba1 
>   util/environmentselectionwidget.cpp a198f32 
> 
> Diff: http://git.reviewboard.kde.org/r/108212/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131205/b44f3799/attachment.html>