Review Request 114237: php language support: use importsCache

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114237/#review44939
-----------------------------------------------------------

Ship it!


And the performance is noticeably improved? The existing benchmarks probably don't catch this as they only test the single-file parsing. Can we construct a benchmark for this maybe?

Otherwise fine with me if this helps :)

- Milian Wolff


On Dec. 1, 2013, 2:59 p.m., Niko Sams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114237/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2013, 2:59 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-php
> 
> 
> Description
> -------
> 
> This patch greatly improves performance for larger projects where one class is used in hundreds of others. Eg. an Exception class that is used everywhere.
> 
> 
> Diffs
> -----
> 
>   duchain/builders/contextbuilder.cpp 134024e 
>   duchain/helper.cpp f3f40eb 
> 
> Diff: http://git.reviewboard.kde.org/r/114237/diff/
> 
> 
> Testing
> -------
> 
> - unittests pass (except one problem in completiontest, I still have to look into this)
> - big project i tested with fully parses, and everything works as expected
> 
> I will do further real-world-testing the next week with this patch applied.
> 
> 
> Thanks,
> 
> Niko Sams
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131201/5ed8ab6f/attachment-0001.html>