Review Request 112039: Add a CPU registers view.

[Aleix Pol Gonzalez]

> On Aug. 24, 2013, 12:28 p.m., Milian Wolff wrote:
> > debuggers/gdb/registers/registersview.cpp, line 60
> > <http://git.reviewboard.kde.org/r/112039/diff/4/?file=184225#file184225line60>
> >
> >     Oh sorry, I just saw that. This is a no-go. Please use Qt's Model/View paradigm instead of the deprecated QTableWidgetItem stuff.
> >     
> >     Generally, this might also be something you could use to simplify the codebase a bit. Each register can be represented as a model with an additional title.
> >     
> >     Hm but considering how long this is already in review, maybe we should first merge it as-is once it is otherwise OK and then you can clean this up and remove the QTableWidgetItem stuff and port it to Model/View?
> 
> Vlas Puhov wrote:
>       It doesn't seem like it deprecated at all. At least I can't find any information about it neither in qt4 nor in qt5 documentations...
>       Anyhow I'm not sure if I can do it, at least not now (my experience with Model/View stuff is very limited. For me it's a way too overwhelming)
>      So, can we merge it as-is then? Please!!!

I also would prefer if you didn't use QTreeWidget.

You can use QStandardItemModel+QTreeView instead very easily, you'll have to actually change few things.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112039/#review38475
-----------------------------------------------------------


On Aug. 27, 2013, 8:15 p.m., Vlas Puhov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112039/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 8:15 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Supported architectures: x86/x86_64, arm v7(v6 should work too).
> Features: x86/x86_64: General registers/flags, segment, FPU registers read/write. XMM - read only.
> arm: General registers/flags, VFP single - read/write, other - read only.
> 
> Related changes:
> DisassembleWidget: removed startAddress and endAddress combo boxes so as to let to resize disassemble view, but the change address functionality is still there through context menu.
> FramestackModel: if first frame doesn't contain debug information don't set currentPosition to the first frame with debug information. It allows to keep synchronization between views(gdb, editor, disassemble widget and registers) otherwise all these views'll be in different states.
> 
> 
> This addresses bug 273152.
>     http://bugs.kde.org/show_bug.cgi?id=273152
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/CMakeLists.txt 32ef14f 
>   debuggers/gdb/debuggerplugin.cpp 3533cdb 
>   debuggers/gdb/disassemblewidget.h 81c25fc 
>   debuggers/gdb/disassemblewidget.cpp e1d6e8f 
>   debuggers/gdb/registers/registercontroller.h PRE-CREATION 
>   debuggers/gdb/registers/registercontroller.cpp PRE-CREATION 
>   debuggers/gdb/registers/registercontroller_arm.h PRE-CREATION 
>   debuggers/gdb/registers/registercontroller_arm.cpp PRE-CREATION 
>   debuggers/gdb/registers/registercontroller_x86.h PRE-CREATION 
>   debuggers/gdb/registers/registercontroller_x86.cpp PRE-CREATION 
>   debuggers/gdb/registers/registersmanager.h PRE-CREATION 
>   debuggers/gdb/registers/registersmanager.cpp PRE-CREATION 
>   debuggers/gdb/registers/registersview.h PRE-CREATION 
>   debuggers/gdb/registers/registersview.cpp PRE-CREATION 
>   debuggers/gdb/registers/registersview.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112039/diff/
> 
> 
> Testing
> -------
> 
> Manual only for x86/x86_64 and armv7 architectures 
> 
> 
> File Attachments
> ----------------
> 
> Related changes in kdevplatform
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/12/framestackmodel.diff
> Updated GUI
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/GUI.7z
> 
> 
> Thanks,
> 
> Vlas Puhov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130827/5f6c29a4/attachment.html>