Review Request 112231: Remove the area switching tabs

[Milian Wolff]

> On Aug. 26, 2013, 8:55 a.m., Milian Wolff wrote:
> > plugins/standardoutputview/standardoutputview.cpp, line 27
> > <http://git.reviewboard.kde.org/r/112231/diff/2/?file=184650#file184650line27>
> >
> >     Remove this again
> 
> Aleix Pol Gonzalez wrote:
>     How can this be related to the review?
> 
> Sven Brauch wrote:
>     I guess because you added it in the review? ;)

Maybe an artefact? I thought I deleted all these lines in master, maybe it's just b/c this branch is not up2date? Anyhow, just make sure you don't re-add this line please.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112231/#review38593
-----------------------------------------------------------


On Aug. 26, 2013, 1:38 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112231/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 1:38 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> The area switching tabs is something that has bothered me quite a bit recently. It's something that is always visible in the screen and we barely use it. There's very little point to explicitly changing to an area, we usually do it from an action: debug, show differences, etc. These are specified by a new Area::addAction(QAction*) method.
> 
> This patch changes the current tab interface (inspired from Eclipse IIRC), for a button that tells the user what's the current area and where we can go.
> 
> The patch also removes the tabs and some unneeded abstractions in sublime/mainwindow that where only used by the tabs.
> 
> 
> Diffs
> -----
> 
>   plugins/patchreview/patchreview.h 519c009 
>   plugins/patchreview/patchreview.cpp dd54c8b 
>   plugins/patchreview/patchreviewtoolview.cpp fd2799a 
>   plugins/standardoutputview/standardoutputview.cpp 60379a9 
>   shell/CMakeLists.txt fe5cd9b 
>   shell/areadisplay.h PRE-CREATION 
>   shell/areadisplay.cpp PRE-CREATION 
>   shell/debugcontroller.h a8f215f 
>   shell/debugcontroller.cpp cc3ae52 
>   shell/mainwindow.h 2050219 
>   shell/mainwindow.cpp d4f4bcb 
>   shell/projectcontroller.cpp 2186d90 
>   shell/runcontroller.cpp 4a5a5e4 
>   shell/sessionlock.h fb5e779 
>   shell/uicontroller.cpp 2c0400f 
>   sublime/area.h 878c120 
>   sublime/area.cpp df29ce3 
>   sublime/blur.h 684ff8f 
>   sublime/mainwindow.h 96b9e71 
>   sublime/mainwindow.cpp f405200 
>   sublime/mainwindow_p.h 7885d06 
>   sublime/mainwindow_p.cpp 23c638d 
>   util/projecttestjob.h 79b6f7d 
>   util/projecttestjob.cpp 3d22fa5 
> 
> Diff: http://git.reviewboard.kde.org/r/112231/diff/
> 
> 
> Testing
> -------
> 
> Been using it for a couple of days, seems safe.
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/23/pairs-credits2.png
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/23/pairs-credits2_1.png
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/23/pairs-credits2_2.png
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130826/d0012795/attachment.html>