[kdevplatform/noAreaTabs] shell: Use QToolButton instea do QPushButton.

Aleix Pol aleixpol at kde.org
Sun Aug 25 23:40:16 UTC 2013

On Mon, Aug 26, 2013 at 12:48 AM, Milian Wolff <mail at milianw.de> wrote:

> On Monday 26 August 2013 00:36:34 Aleix Pol wrote:
> > Well... I actually tested it and didn't. I don't really mind but you
> could
> > have said that on the review...
> Sorry, I didn't assume you tested it with QToolButton and thought it's
> simpler
> if I try it out myself and see whether it looks better or not.
> Why did you prefer the QPushButton variant? Personally, I prefer the
> QToolButton as it is not as cramped as the QPushButton variant, the margins
> look better.
> Should I show before/after screenshots?
> Cheers
> --
> Milian Wolff
> mail at milianw.de
> http://milianw.de

I was getting a flat button, which integrates better with the menu (see
review screenshot), although I realize I didn't leave it explicitly (I had
some battling done to make sure there's no gray space between the menu and
the toolbar anymore).

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130826/1a8c3664/attachment.html>

More information about the KDevelop-devel mailing list