Review Request 112226: Add CLI option to open files in running instances

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112226/#review38553
-----------------------------------------------------------



app/main.cpp
<http://git.reviewboard.kde.org/r/112226/#comment28504>

    const& for files



app/main.cpp
<http://git.reviewboard.kde.org/r/112226/#comment28506>

    this part here could/should also move into a separate function, pass along what you need. Then depending on what is returned, return from main as well.



app/main.cpp
<http://git.reviewboard.kde.org/r/112226/#comment28508>

    first check for "open-session" or "new-session" and then fill candidates. Also, if "-s" is passed, isn't that exactly like a list of candidates with a single entry?



app/main.cpp
<http://git.reviewboard.kde.org/r/112226/#comment28507>

    no need, just "return 1", or well, if thats a free function just propagate.


- Milian Wolff


On Aug. 24, 2013, 11:18 a.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112226/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 11:18 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This feature has been requested various times by various users,
> and I'd like to have it too.
> 
> The new option is -o <filename> / --open-file <filename>.
> Logic:
>  * If no sessions are running, behaves like "kdevelop <file>".
>  * If exactly one session is running, opens the file in that session
>  * Otherwise, shows the session picker and opens the file in that session
> 
> 
> Diffs
> -----
> 
>   app/main.cpp 12fa0e0 
> 
> Diff: http://git.reviewboard.kde.org/r/112226/diff/
> 
> 
> Testing
> -------
> 
> Tested all three cases, works
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130825/62846fdd/attachment.html>