Review Request 112084: Relative imports from "." are properly parsed

Zaar Hai haizaar at haizaar.com
Mon Aug 19 20:54:21 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112084/
-----------------------------------------------------------

(Updated Aug. 19, 2013, 8:54 p.m.)


Review request for KDevelop.


Changes
-------

Hmm, strange. I've pulled the master first.
After re-cloning master and applying my diff, the generated patch uploaded correctly. Please have a look.

P.S. Unit tests are on the way.

Zaar


Description
-------

This patch makes imports like
from . import Foo
from .. import Bar

when Foo and Bar are defined in respective __init__.py files.


Diffs (updated)
-----

  duchain/declarationbuilder.h c45a9c3 
  duchain/declarationbuilder.cpp 5d6fcee 

Diff: http://git.reviewboard.kde.org/r/112084/diff/


Testing
-------

1. make test passed
2. All of my python project tree shows not a single import error


File Attachments
----------------

The new patch
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/19/0001-Relative-imports-from-.-are-properly-parsed_1.patch


Thanks,

Zaar Hai

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130819/b8cfef74/attachment.html>


More information about the KDevelop-devel mailing list