Review Request 112078: Creates a new file when trying to open a nonexistent file

[Jørgen Kvalsvik]

> On Aug. 14, 2013, 12:49 p.m., Aleix Pol Gonzalez wrote:
> > I don't think this is an obvious work-flow. I understand that it could useful but I don't think that removing the check is going to improve our life at all.
> > 
> > The user needs some feedback at least, that whenever he saves the document he'll be actually creating it.
> 
> Jørgen Kvalsvik wrote:
>     Do you mean feedback as in it won't actually be created until he saves? I suppose that would be ok, especially if we can add a "Do not notify me again"-option.
> 
> Jørgen Kvalsvik wrote:
>     I considered this for a while. The not-creating-before-it-is-saved actually applies to when you create a new file/buffer with Ctrl+N as well, so there is no reason for it to be different if you open with Ctrl+O. The fact that the semantic here is "open" also implies that it won't actually be written to disk before you flush it.
> 
> Jørgen Kvalsvik wrote:
>     Oh, and Kate already behaves like this.
> 
> Aleix Pol Gonzalez wrote:
>     No, with Ctrl+N you're being explicit.
>     
>     Also it doesn't have to be a message box, you can use Kate's notifying system.
>     
>     The fact that Kate behaves like this at the moment doesn't make it any better ;). In fact, it's a fix that probably should go in Kate. I think this review can wait until then, because it's quite simple and it will bring an overall better look&feel.

You're being explicit, yes, but the file itself won't be written to the file system before you flush the buffer. Like every other editor I can think of.

A notification is OK, but in that case Kate should get it too, in the name of consistency. Right now KDevelop is the odd one out NOT opening a new buffer with the open-file-dialogue.


- Jørgen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112078/#review37759
-----------------------------------------------------------


On Aug. 14, 2013, 10:04 a.m., Jørgen Kvalsvik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112078/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2013, 10:04 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Removes the check if a file exists (KIO::NetAccess::exists()) so that the following routines will create the file instead of just attempting to open it.
> 
> 
> This addresses bug 322678.
>     http://bugs.kde.org/show_bug.cgi?id=322678
> 
> 
> Diffs
> -----
> 
>   shell/documentcontroller.cpp 4fd2819 
> 
> Diff: http://git.reviewboard.kde.org/r/112078/diff/
> 
> 
> Testing
> -------
> 
> Tested both opening and creating files through the open file dialogue. Confirmed that creating files with File->New works as well.
> 
> 
> Thanks,
> 
> Jørgen Kvalsvik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130816/0a954841/attachment.html>