Review Request 112100: Support for unittest python assets and some basic cleanup

Zaar Hai haizaar at haizaar.com
Thu Aug 15 17:01:24 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112100/
-----------------------------------------------------------

(Updated Aug. 15, 2013, 5:01 p.m.)


Review request for KDevelop.


Changes
-------

Fixed most of the issues.


Description
-------

* Each test now can have python files in duchain/tests/data/<testFunctionName>
* Those files will be automatically parsed before test function gets invoked
* Temporary directory is created before test start and all TestFiles are staged there (instead of /tmp)

Sven,
* Please have a look at my FIXME lines - I'm not sure what is the right way to abort tests execution
* I've changed testImportDeclarations test a bit (the second data line) - please have a look that I did not do anything stupid

Thanks,
Zaar


Diffs (updated)
-----

  duchain/tests/CMakeLists.txt 7ff16e2 
  duchain/tests/data/testImportDeclarations/i.py PRE-CREATION 
  duchain/tests/data/testInheritance/i.py PRE-CREATION 
  duchain/tests/data/testMultiFromImport/i.py PRE-CREATION 
  duchain/tests/pyduchaintest.h 5fddab4 
  duchain/tests/pyduchaintest.cpp 00573be 

Diff: http://git.reviewboard.kde.org/r/112100/diff/


Testing
-------

make test


Thanks,

Zaar Hai

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130815/5215e6d4/attachment.html>


More information about the KDevelop-devel mailing list