Review Request 112084: Relative imports from "." are properly parsed

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112084/#review37776
-----------------------------------------------------------

Ship it!


Looks good!

It would still be totally awesome if you could write unit tests for this ;)


duchain/declarationbuilder.cpp
<http://git.reviewboard.kde.org/r/112084/#comment27982>

    Please use QString, the char* trouble isn't worth it.



duchain/declarationbuilder.cpp
<http://git.reviewboard.kde.org/r/112084/#comment27984>

    inconsistent formatting, please use if ( foo )



duchain/declarationbuilder.cpp
<http://git.reviewboard.kde.org/r/112084/#comment27983>

    Why did you remove this? The "try twice" approach is still quite bad ;)


- Sven Brauch


On Aug. 14, 2013, 3:17 p.m., Zaar Hai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112084/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2013, 3:17 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This patch makes imports like
> from . import Foo
> from .. import Bar
> 
> when Foo and Bar are defined in respective __init__.py files.
> 
> 
> Diffs
> -----
> 
>   duchain/declarationbuilder.h c45a9c3 
>   duchain/declarationbuilder.cpp 5d6fcee 
> 
> Diff: http://git.reviewboard.kde.org/r/112084/diff/
> 
> 
> Testing
> -------
> 
> 1. make test passed
> 2. All of my python project tree shows not a single import error
> 
> 
> Thanks,
> 
> Zaar Hai
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130814/6aca5d6e/attachment-0001.html>