Review Request 112078: Creates a new file when trying to open a nonexistent file

Aleix Pol Gonzalez aleixpol at kde.org
Wed Aug 14 12:49:30 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112078/#review37759
-----------------------------------------------------------


I don't think this is an obvious work-flow. I understand that it could useful but I don't think that removing the check is going to improve our life at all.

The user needs some feedback at least, that whenever he saves the document he'll be actually creating it.

- Aleix Pol Gonzalez


On Aug. 14, 2013, 10:04 a.m., Jørgen Kvalsvik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112078/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2013, 10:04 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Removes the check if a file exists (KIO::NetAccess::exists()) so that the following routines will create the file instead of just attempting to open it.
> 
> 
> This addresses bug 322678.
>     http://bugs.kde.org/show_bug.cgi?id=322678
> 
> 
> Diffs
> -----
> 
>   shell/documentcontroller.cpp 4fd2819 
> 
> Diff: http://git.reviewboard.kde.org/r/112078/diff/
> 
> 
> Testing
> -------
> 
> Tested both opening and creating files through the open file dialogue. Confirmed that creating files with File->New works as well.
> 
> 
> Thanks,
> 
> Jørgen Kvalsvik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130814/feda2451/attachment.html>


More information about the KDevelop-devel mailing list