Review Request 109829: Why do we need restoreState?

Aleix Pol Gonzalez aleixpol at
Mon Aug 5 21:09:21 UTC 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 5, 2013, 9:09 p.m.)


This change has been discarded.

Review request for KDevelop and Alexander Dymo.


I had been hitting some ugly bug recently, where KDevelop would initialize in a weird state where one of the docks was shown but the button wasn't checked, so I had to press the button to hide it (hotkeys didn't work).

I decided to investigate when were the hidden toolviews shown. gdb soon suggested it was in restoreState(). I started to fiddle with the code to see what could be wrong, but I couldn't manage to find out, so I tried to disable it. It worked (surprisingly good I must add, most of the glitches I had when changing areas are gone with this change).

This is not a proper review request, but I was wondering what are we trying to restore there. Toolviews and menues are managed elsewhere, so are the document views. The size isn't being restored there either (load/saveGeometry).

This addresses bug 295536.


  sublime/mainwindow.cpp 9d55ca6 



All tests pass (but testgenerationtest), didn't add any other test.


Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list