Review Request 111815: Quick open plugin: Hide vertical scrollbar instead of disabling it.

[Milian Wolff]

> On July 31, 2013, 9:18 p.m., Milian Wolff wrote:
> > No, I'm afraid I don't like this change.
> > 
> > a) it introduces flickering when the magic limit is reached and the scroll bar is hidden.
> > b) hiding the scrollbar when there is something to scroll is bad.
> > 
> > I agree that making it un-scrollable is also a bad choice, but I think its better than the above. Imo, the proper fix would be benchmark this and see whats going on and whether one could improve the situation that way instead. I'll have a look at that now.

I've fixed this properly now by caching the QPixmaps for the icon names. This greatly improves the speed and we can simply enable the scrollbar always again.

Thanks for bringing this up! I'll close this review request now as its not required anymore.

Cheers


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111815/#review36886
-----------------------------------------------------------


On July 31, 2013, 2:07 p.m., Vlas Puhov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111815/
> -----------------------------------------------------------
> 
> (Updated July 31, 2013, 2:07 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> When there is too many items in the list the scrollbar is disabled. It looks very odd(I've never seen a disabled scrollbar before). Furthermore it's not so obvious that it's disabled(I figured it out only from the third try).
> 
> 
> Diffs
> -----
> 
>   plugins/quickopen/quickopenplugin.h 6de4bd0 
>   plugins/quickopen/quickopenplugin.cpp 3fe08af 
> 
> Diff: http://git.reviewboard.kde.org/r/111815/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vlas Puhov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130801/f1049ba3/attachment.html>