Review Request 110215: Do not cache resolved executable path
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Apr 30 18:03:41 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110215/
-----------------------------------------------------------
(Updated April 30, 2013, 6:03 p.m.)
Status
------
This change has been discarded.
Review request for KDevelop.
Description
-------
Path to an execytable depends on a build dir for current configuration
in case RUNTIME_OUTPUT_DIRECTORY property is set on an executable cmake
target and relies on build dir. Caching resolved path leads to execution
of a binary from a configuration which was active during project load.
BUG: 317587
This addresses bug 317587.
http://bugs.kde.org/show_bug.cgi?id=317587
Diffs
-----
projectmanagers/cmake/cmakemanager.cpp 9b00d06
projectmanagers/cmake/cmakemodelitems.h b07be68
projectmanagers/cmake/cmakemodelitems.cpp 3665ac4
Diff: http://git.reviewboard.kde.org/r/110215/diff/
Testing
-------
Run unit tests related to cmake. Manually tested creation launch configuration from target, switching between build directories when RUNTIME_OUTPUT_DIRECTORY property is set.
File Attachments
----------------
Formatted patch
http://git.reviewboard.kde.org/media/uploaded/files/2013/04/27/0001-Postpone-executable-target-path-resolution.patch
Thanks,
Sergey Vidyuk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130430/c1f52083/attachment.html>
More information about the KDevelop-devel
mailing list