Review Request 110215: Do not cache resolved executable path

[Sergey Vidyuk]

> On April 29, 2013, 11:33 a.m., Aleix Pol Gonzalez wrote:
> > Projects are re-parsed when you change the build directory, this shouldn't be needed, or at least this doesn't look like the correct fix.

kDebug(9515) << "---> CMakeManager::parse" << item->folderName(); in the verry beggining of the CMakeManager::parse methods shows that project parsed on open but not on build dir change. Probably this is original source of the issue.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110215/#review31750
-----------------------------------------------------------


On April 27, 2013, 8:30 a.m., Sergey Vidyuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110215/
> -----------------------------------------------------------
> 
> (Updated April 27, 2013, 8:30 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Path to an execytable depends on a build dir for current configuration
> in case RUNTIME_OUTPUT_DIRECTORY property is set on an executable cmake
> target and relies on build dir. Caching resolved path leads to execution
> of a binary from a configuration which was active during project load.
> 
> BUG: 317587
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/cmakemanager.cpp 9b00d06 
>   projectmanagers/cmake/cmakemodelitems.h b07be68 
>   projectmanagers/cmake/cmakemodelitems.cpp 3665ac4 
> 
> Diff: http://git.reviewboard.kde.org/r/110215/diff/
> 
> 
> Testing
> -------
> 
> Run unit tests related to cmake. Manually tested creation launch configuration from target, switching between build directories when RUNTIME_OUTPUT_DIRECTORY property is set.
> 
> 
> File Attachments
> ----------------
> 
> Formatted patch
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/27/0001-Postpone-executable-target-path-resolution.patch
> 
> 
> Thanks,
> 
> Sergey Vidyuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130429/b884a603/attachment.html>