Review Request 110107: Remove the random icons from working sets

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110107/#review31363
-----------------------------------------------------------


Technically the diff looks ok to me and I think this representation of workingsets makes as much sense as random icons.

Since IIRC you're using a dark color-scheme the color-choosing algorithm works well in that? Also does it always give big enough contrast to the background?

- Andreas Pakulat


On April 20, 2013, 11:16 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110107/
> -----------------------------------------------------------
> 
> (Updated April 20, 2013, 11:16 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Currently each working set gets a random icon from some application, which looks very weird. For example, it used the alarm function icon, and did lots of things like desaturate it, which in the end made everything look very confusing and messy in my opinion.
> This patch instead replaces the icons by colored dots, inspired by konversation's default nicklist icons. They are easy to differentiate, look clean, and are not associated with totally different things by the user.
> 
> Additionally, the new icons are generated at run-time, and are completely calculated from the working set's ID. Thus, lots of messy code which iterates through possible icons, checks if they're already being used, saves them to a config file, loads them from a config file etc. was removed. Of course this comes at the price of painting the new icons, but the code doing that is contained in one single, obvious function and not splattered around everywhere. Also, the icons are no longer involved in deciding which working sets should be loaded on startup (sic).
> 
> It could be discussed if the icon could still be improved optically, especially I don't like the blue vs. darkgrey contrast too much -- suggestions are welcome!
> 
> 
> Diffs
> -----
> 
>   shell/workingsetcontroller.h 9697a99 
>   shell/workingsetcontroller.cpp 3b4f90c 
>   shell/workingsets/workingset.h ae2aa94 
>   shell/workingsets/workingset.cpp cac0d54 
>   shell/workingsets/workingsettoolbutton.cpp c890049 
> 
> Diff: http://git.reviewboard.kde.org/r/110107/diff/
> 
> 
> Testing
> -------
> 
> Manually tested creating and removing working sets in various conditions, and also tested closing and re-opening kdevelop with various working set setups. Seems okay.
> 
> 
> File Attachments
> ----------------
> 
> old workingset icons
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/20/workingsets.png
> new workingset icons
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/20/workingsets_new.png
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130421/6a380382/attachment.html>