Review Request 108482: Title bar now correctly updades after Open/Import or Close Project

Milian Wolff mail at milianw.de
Sun Apr 14 21:19:41 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108482/#review31031
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On April 13, 2013, 5:36 p.m., Lambert Clara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108482/
> -----------------------------------------------------------
> 
> (Updated April 13, 2013, 5:36 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> On a newly created session, the mainwindow name remained at (no projects) after an Open/Import project, and was not updated when a project was closed.
> If kdevelop was opened with an already existing session, the title bar was ok.
> 
> This was due to the SessionInfo's project list, which was not updated when loading/closing a project. However, the config group was, explaining why it worked at reboot.
> 
> 
> Diffs
> -----
> 
>   shell/session.h d47ec41 
>   shell/session.cpp a59d70e 
>   shell/sessioncontroller.cpp ef5c845 
> 
> Diff: http://git.reviewboard.kde.org/r/108482/diff/
> 
> 
> Testing
> -------
> 
> Open/Import multiple projects on a newly created session, and close them. Open multiple instances of kdevelop and do the same.
> Launch ctest, 100% tests passed, 0 tests failed out of 43.
> 
> 
> Thanks,
> 
> Lambert Clara
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130414/5241b1ee/attachment.html>


More information about the KDevelop-devel mailing list