Review Request 109986: Documents sidebar categorization by path

[Sebastian Kügler]

> On April 13, 2013, 10:47 a.m., Andreas Pakulat wrote:
> > plugins/documentview/kdevdocumentviewdelegate.cpp, line 41
> > <http://git.reviewboard.kde.org/r/109986/diff/1/?file=138480#file138480line41>
> >
> >     Whats the reason for this?

I've been trying folder icons instead of the expand indicator there, it works OK, but looks a bit more crowded. I'll remove this. (Also will save a KIcon construction elsewhere).


> On April 13, 2013, 10:47 a.m., Andreas Pakulat wrote:
> > plugins/documentview/kdevdocumentviewdelegate.cpp, line 77
> > <http://git.reviewboard.kde.org/r/109986/diff/1/?file=138480#file138480line77>
> >
> >     Hmm, this seems to still elide the text - according to your screenshot. So I guess the elidedText function call was never needed?

I *want* to elide the text (the full path is shown in the tooltip). In the original, the label for categories (mimetypes there) is centered, that doesn't look good for paths and makes it harder to read. So we align left, and elide, if the user needs to see the whole path, she can either make the view wider, or hover with the mouse to see the tooltip. I've tried eliding on different sides (left, middle, right), all but elide right feels weird.

IMO, this should stay as it is.


On April 13, 2013, 10:47 a.m., Sebastian Kügler wrote:
> > In general I think the change is great.

Cool, I'll address the issues you pointed out, and will submit an updated version. (Not sure when I get to it, but I'll make sure it won't drop off the table.)

Also, thanks for the quick review.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109986/#review30977
-----------------------------------------------------------


On April 12, 2013, 11:50 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109986/
> -----------------------------------------------------------
> 
> (Updated April 12, 2013, 11:50 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This patch changes the categorization in KDevelop's Documents sidebar to categorizing by path, not by mimetype anymore.
> 
> The problems with sorting by mimetypes are:
> 
> - files that are related to each other are often far away in the UI
> - there are often files with the same name right underneath each other, making picking the right one almost impossible
> 
> With this patch, the sidebar is organized per path, in alphabetical order. This makes the location of a file in the UI more predictable, groups file in a more meaningful way.
> 
> 
> I've asked a few people on IRC about this, nobody was particularly attached to the current design, so I changed the current one, instead of adding a new plugin. (It makes sense to me personally as well, I don't see how categorization by mimetype there is useful, but my use case is rather limited).
> 
> Please give it a try, tell me what you think of it. You can find the code in the sebas/sidebar branch in kdevplatform.
> 
> 
> Diffs
> -----
> 
>   plugins/documentview/kdevdocumentviewdelegate.cpp b172ac0d5b2c1a60cbd45d26e30b72ef725d8678 
>   plugins/documentview/kdevdocumentview.desktop.cmake a89e79e18a9b79becd669813ead2d2e31f588a4d 
>   plugins/documentview/kdevdocumentview.cpp b8c4a02ad31fb8aaf29691d7d7d991c4b699360e 
>   plugins/documentview/kdevdocumentview.h e237f1050aee6c4ef383c809d929b524f94cb938 
>   plugins/documentview/kdevdocumentmodel.cpp b411a815680ee92d8eaf81b19266f24c6b4a4f13 
>   plugins/documentview/kdevdocumentmodel.h 05cff452c403156cd53e9caaf029d6bbcd394862 
> 
> Diff: http://git.reviewboard.kde.org/r/109986/diff/
> 
> 
> Testing
> -------
> 
> Tested with my actual projects, behaviour feels much better, I now (kind of ;)) enjoy the sidebar, rather than outright hating it. :-)
> 
> I didn't notice any particular misbehaviour or breakage, performance also doesn't seem to be a problem.
> 
> 
> File Attachments
> ----------------
> 
> original sidebar
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/12/kdevelop-sidebar-original.png
> new sidebar
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/12/kdevelop-sidebar-new.png
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130413/818e455a/attachment.html>