Review Request 109863: Fix codeutils's testgenerationtest

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109863/#review30923
-----------------------------------------------------------

Ship it!


looks good - sorry that I missed that :(

- Milian Wolff


On April 4, 2013, 8:37 p.m., Nicolas Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109863/
> -----------------------------------------------------------
> 
> (Updated April 4, 2013, 8:37 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> In e417ab76, Milian refactored some code related to templates and fixed the tests in language/codegen/tests to match. However, the test in plugins/codeutils/tests didn't get fixed in the same way and it has been broken since then.
> 
> This patch modifies testgenerationtest (and the build system around it) in a similar way to what Milian did for the codegen tests. I don't really understand all the code involved.
> 
> 
> Diffs
> -----
> 
>   plugins/codeutils/tests/codeutils_tests_config.h.cmake 43a85db 
>   plugins/codeutils/tests/CMakeLists.txt fd31c59 
>   plugins/codeutils/tests/templates/CMakeLists.txt  
>   plugins/codeutils/tests/templates/test_qtestlib/class.h  
>   plugins/codeutils/tests/templates/test_qtestlib/class.cpp  
>   plugins/codeutils/tests/templates/test_qtestlib/test_qtestlib.desktop  
>   plugins/codeutils/tests/templates/test_yaml/class.yaml  
>   plugins/codeutils/tests/templates/test_yaml/test_yaml.desktop  
>   plugins/codeutils/tests/testgenerationtest.cpp 78f6c24 
> 
> Diff: http://git.reviewboard.kde.org/r/109863/diff/
> 
> 
> Testing
> -------
> 
> All of kdevplatform compiles and this test now passes:
> 
> Totals: 4 passed, 0 failed, 0 skipped
> ********* Finished testing of TestGenerationTest *********
> 
> 
> Thanks,
> 
> Nicolas Alvarez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130411/4607a748/attachment.html>