Review Request 109776: add _NET_WM_WINDOW_TYPE to new splashscreen

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109776/#review30786
-----------------------------------------------------------


This review has been submitted with commit d7e61dd231416f982c0e297966d8baa1ea07ec32 by Milian Wolff on behalf of Marcel Hellwig to branch master.

- Commit Hook


On March 28, 2013, 6:02 p.m., Marcel Hellwig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109776/
> -----------------------------------------------------------
> 
> (Updated March 28, 2013, 6:02 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> The new splash screen does not set the _NET_WM_WINDOW_TYPE to _NET_WM_WINDOW_TYPE_SPLASH, although it should be as it is mentioned in QSplashScreen. It's annoying in s twm (i3).
> 
> As a "proof" here is a xprop extract.
> 
> before:
> WM_STATE(WM_STATE):
> 		window state: Normal
> 		icon window: 0x0
> _NET_WM_STATE(ATOM) = _NET_WM_STATE_ABOVE, _NET_WM_STATE_STAYS_ON_TOP
> _NET_WM_WINDOW_TYPE(ATOM) = _KDE_NET_WM_WINDOW_TYPE_OVERRIDE, _NET_WM_WINDOW_TYPE_NORMAL
> _MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x3, 0x4, 0x0, 0x0, 0x0
> WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW, WM_TAKE_FOCUS, _NET_WM_PING, _NET_WM_SYNC_REQUEST
> WM_NAME(STRING) = "kdevelop"
> WM_LOCALE_NAME(STRING) = "en_US.utf8"
> WM_CLASS(STRING) = "kdevelop", "Kdevelop"
> WM_HINTS(WM_HINTS):
> 		Client accepts input or input focus: True
> 		Initial state is Normal State.
> 		bitmap id # to use for icon: 0x3400014
> 		window id # of group leader: 0x3400004
> WM_NORMAL_HINTS(WM_SIZE_HINTS):
> 		user specified location: 563, 300
> 		program specified location: 563, 300
> 		user specified size: 475 by 301
> 		program specified size: 475 by 301
> 		program specified minimum size: 475 by 301
> 		program specified maximum size: 475 by 301
> 		window gravity: Static
> WM_COMMAND(STRING) = { "kdevelop" }
> 
> after:
> WM_STATE(WM_STATE):
> 		window state: Normal
> 		icon window: 0x0
> _NET_WM_SYNC_REQUEST_COUNTER(CARDINAL) = 54525975
> _NET_WM_STATE(ATOM) = _NET_WM_STATE_ABOVE, _NET_WM_STATE_STAYS_ON_TOP
> WM_TRANSIENT_FOR(WINDOW): window id # 0x3400004
> WM_CLIENT_LEADER(WINDOW): window id # 0x3400004
> _NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_SPLASH, _KDE_NET_WM_WINDOW_TYPE_OVERRIDE, _NET_WM_WINDOW_TYPE_NORMAL
> WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW, WM_TAKE_FOCUS, _NET_WM_PING, _NET_WM_SYNC_REQUEST
> WM_NAME(STRING) = "kdevelop"
> WM_LOCALE_NAME(STRING) = "en_US.utf8"
> WM_CLASS(STRING) = "kdevelop", "Kdevelop"
> WM_HINTS(WM_HINTS):
> 		Client accepts input or input focus: True
> 		Initial state is Normal State.
> 		bitmap id # to use for icon: 0x3400014
> 		window id # of group leader: 0x3400004
> WM_NORMAL_HINTS(WM_SIZE_HINTS):
> 		user specified location: 563, 300
> 		program specified location: 563, 300
> 		user specified size: 475 by 301
> 		program specified size: 475 by 301
> 		program specified minimum size: 475 by 301
> 		program specified maximum size: 475 by 301
> 		window gravity: NorthWest
> WM_COMMAND(STRING) = { "kdevelop" }
> 
> I think this is a bug in QSplashScreen but I don't know and this fix it for me.
> 
> Regards
> 
> 
> Diffs
> -----
> 
>   app/splash.cpp 5e932c2 
> 
> Diff: http://git.reviewboard.kde.org/r/109776/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done. It will now be displayed properly.
> 
> 
> Thanks,
> 
> Marcel Hellwig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130409/0432dc3a/attachment.html>